<html>
<head><meta charset="utf-8"><title>rust.ungram didnt update on publish · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rust.2Eungram.20didnt.20update.20on.20publish.html">rust.ungram didnt update on publish</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="220107199"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rust.ungram%20didnt%20update%20on%20publish/near/220107199" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Wirth <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rust.2Eungram.20didnt.20update.20on.20publish.html#220107199">(Dec 16 2020 at 12:05)</a>:</h4>
<p>I'm not sure why but for some reason the 1.3.0 ungrammar release doesn't contain the new ungrammar <a href="https://docs.rs/crate/ungrammar/1.3.0/source/rust.ungram">https://docs.rs/crate/ungrammar/1.3.0/source/rust.ungram</a></p>



<a name="220107212"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rust.ungram%20didnt%20update%20on%20publish/near/220107212" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Wirth <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rust.2Eungram.20didnt.20update.20on.20publish.html#220107212">(Dec 16 2020 at 12:06)</a>:</h4>
<p>The macro 2.0 stuff landed in it, but the lifetime changes are missing</p>



<a name="220107297"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rust.ungram%20didnt%20update%20on%20publish/near/220107297" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Wirth <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rust.2Eungram.20didnt.20update.20on.20publish.html#220107297">(Dec 16 2020 at 12:06)</a>:</h4>
<p>oh</p>



<a name="220107342"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rust.ungram%20didnt%20update%20on%20publish/near/220107342" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Wirth <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rust.2Eungram.20didnt.20update.20on.20publish.html#220107342">(Dec 16 2020 at 12:07)</a>:</h4>
<p><strong>Jonas Schievink</strong>  published 1.3.0 10 minutes before i merged this that explains it <span aria-label="big smile" class="emoji emoji-1f604" role="img" title="big smile">:big_smile:</span></p>



<a name="220107457"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rust.ungram%20didnt%20update%20on%20publish/near/220107457" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rust.2Eungram.20didnt.20update.20on.20publish.html#220107457">(Dec 16 2020 at 12:08)</a>:</h4>
<p>So you need another PR with version bump?</p>



<a name="220107632"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rust.ungram%20didnt%20update%20on%20publish/near/220107632" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Wirth <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rust.2Eungram.20didnt.20update.20on.20publish.html#220107632">(Dec 16 2020 at 12:10)</a>:</h4>
<p>Yep would need another, though maybe its better to wait for the macro 2.0 PR to get done first since I probably need to rebase my stuff on it then anyways, since that will most likely have a few required changes to compile as well?</p>



<a name="220108563"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rust.ungram%20didnt%20update%20on%20publish/near/220108563" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rust.2Eungram.20didnt.20update.20on.20publish.html#220108563">(Dec 16 2020 at 12:20)</a>:</h4>
<p><span class="user-mention" data-user-id="211727">@Jonas Schievink</span> you are now officially in charge of merging lifetimes node-ification work :D</p>



<a name="220109817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rust.ungram%20didnt%20update%20on%20publish/near/220109817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rust.2Eungram.20didnt.20update.20on.20publish.html#220109817">(Dec 16 2020 at 12:35)</a>:</h4>
<p>ungrammar 1.4.0 is published</p>



<a name="220112796"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/rust.ungram%20didnt%20update%20on%20publish/near/220112796" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Wirth <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/rust.2Eungram.20didnt.20update.20on.20publish.html#220112796">(Dec 16 2020 at 13:08)</a>:</h4>
<p>Rebased my PR on yours with ungrammar set to 1.4 and codegen regenerated <span aria-label="thumbs up" class="emoji emoji-1f44d" role="img" title="thumbs up">:thumbs_up:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>